Skip to content

Fixes #243: Defer MPTT recalculation until all changes have been applied #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

Fixes #243: Defer MPTT recalculation until all changes have been applied #244

merged 2 commits into from
Apr 21, 2025

Conversation

jeremystretch
Copy link
Contributor

Fixes: #243

  • Record changed models and call model.objects.rebuild() under a common _cleanup() method on Branch
  • Remove the calls to model.objects.rebuild() from the ObjectChange proxy model

@jeremystretch jeremystretch requested review from a team and cruse1977 April 17, 2025 12:35
@jeremystretch jeremystretch marked this pull request as ready for review April 17, 2025 12:36
@jeremystretch jeremystretch merged commit 25546d4 into main Apr 21, 2025
7 checks passed
@jeremystretch jeremystretch deleted the 243-defer-mptt branch April 21, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthanson arthanson arthanson approved these changes

@cruse1977 cruse1977 Awaiting requested review from cruse1977

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPTT recalculation is forced for every event on branch merge
2 participants
@jeremystretch @arthanson